CMake changes to allow building without lusol #168
Closed
+79
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| option(RESOLVE_TEST_WITH_BSUB | ||
| "Use `jsrun` instead of `mpirun` commands when running tests" OFF) | ||
| option(RESOLVE_USE_KLU "Use KLU, AMD and COLAMD libraries from SuiteSparse" ON) | ||
| option(RESOLVE_USE_LUSOL "Build the LUSOL library" OFF) |
There was a problem hiding this comment.
Off by default...
Comment on lines
+23
to
+26
| if(RESOLVE_USE_LUSOL) | ||
| add_executable(runLUSOLTests.exe runLUSOLTests.cpp) | ||
| target_link_libraries(runLUSOLTests.exe PRIVATE ReSolve resolve_matrix) | ||
| endif() |
There was a problem hiding this comment.
Small changes needed in testing to disable LUSOL...
Comment on lines
+29
to
+33
| set(installable_tests runMatrixIoTests.exe runMatrixHandlerTests.exe | ||
| runMatrixFactorizationTests.exe) | ||
| if(RESOLVE_USE_LUSOL) | ||
| list(APPEND installable_tests runLUSOLTests.exe) | ||
| endif() |
There was a problem hiding this comment.
And here
Comment on lines
+43
to
+45
| if(RESOLVE_USE_LUSOL) | ||
| add_test(NAME lusol_test COMMAND $<TARGET_FILE:runLUSOLTests.exe>) | ||
| endif() |
There was a problem hiding this comment.
And here
Please do. Otherwise this is good to merge. Thank you! |
|
I believe we can close this PR because this issue was addressed in #118. Feel free to reopen, if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My editor screwed with formatting. I can force push to this PR with minimal changes once I disable CMake formatting in my editor...